Improve container#219
Open
thorinaboenke wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
#220
Description
.dockerignore:latestimages to versionsdocker/docker-composeentries todependabot.ymlso pins get bumped automaticallyDockerfile/Dockerfile-devfrom uv pip install to uv sync Using uv lock--no-install-project) followed by the project-install layer, so editing source no longer invalidates the dependency-install cache.also fix bind-mount paths depending on calling directory
docker-compose.ymlanddocker-compose.tls.ymlbuilt bind-mount host paths as$PWD/container/....$PWDis the shell's current directory, nothing to do with where the compose file lives. Runningdocker compose upfromany directory other than the repo root (e.g. from
container/) silently mounted the wrong, non-existent paths (container/container/...)Replaced
$PWD/container/...with./container/.... Composeresolves relative paths involumes:against the compose file's own directoryAdd docker-compose.override.yml to
.gitignoreand shipdocker-compose.override.yml.exampleas a templatemultistage build for fluentd container
How Has This Been Tested?
docker build on both
DockerfileandDockerfile-dev, verifieddetectmate --helpand entry points resolve correctlyConfirmed dependency layer stays
CACHEDon a source-only rebuilddocker compose configvalidates after image pin changesfluentd dry-run works in new image

also ran docker compose with the new fluent image.
Checklist