Skip to content

fix(http): fail fast on HTTP 413 instead of retrying #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(http): fail fast on HTTP 413 instead of retrying #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions airbyte_cdk/sources/streams/http/error_handlers/default_error_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@
failure_type=FailureType.transient_error,
error_message="HTTP Status Code: 408. Error: Request timeout.",
),
413: ErrorResolution(
response_action=ResponseAction.FAIL,
failure_type=FailureType.system_error,
error_message="HTTP Status Code: 413. Error: The request or its response exceeds the size limit accepted by the API.",
),
429: ErrorResolution(
response_action=ResponseAction.RATE_LIMITED,
failure_type=FailureType.transient_error,
Expand Down
9 changes: 9 additions & 0 deletions unit_tests/sources/declarative/requesters/error_handlers/test_default_error_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@
408,
DEFAULT_ERROR_MAPPING[408],
),
(
"_with_http_response_status_413",
413,
ErrorResolution(
response_action=ResponseAction.FAIL,
failure_type=FailureType.system_error,
error_message="HTTP Status Code: 413. Error: The request or its response exceeds the size limit accepted by the API.",
),
),
(
"_with_unmapped_http_status_418",
418,
Expand Down
1 change: 1 addition & 0 deletions ..._tests/sources/declarative/requesters/error_handlers/test_default_http_response_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
pytest.param(403, DEFAULT_ERROR_MAPPING[403], id="403 mapping"),
pytest.param(404, DEFAULT_ERROR_MAPPING[404], id="404 mapping"),
pytest.param(408, DEFAULT_ERROR_MAPPING[408], id="408 mapping"),
pytest.param(413, DEFAULT_ERROR_MAPPING[413], id="413 mapping"),
],
)
def test_matches_mapped_http_status_code(http_code, expected_error_resolution):
Expand Down
Loading