Skip to content

fix(sdk): skip discarded catalog read on background tool-sync failure #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polylane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sdk): skip discarded catalog read on background tool-sync failure #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/core/sdk/src/executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3618,6 +3618,13 @@ export const createExecutor = <const TPlugins extends readonly AnyPlugin[] = rea
integration: String(ref.integration),
connection: String(ref.name),
});
// A background stale-catalog rebuild discards the returned catalog
// (the read answers from the persisted rows), so materializing every
// preserved tool row — the schema columns included — only to drop it
// is a whole-catalog D1 read per reattempt. The rows stay in place;
// skip the copy. An explicit read that joined this in-flight run
// flips `mode()` to "explicit" and still gets the rows.
if (mode() === "background") return [];
const keptRows = yield* core.findMany("tool", { where });
return keptRows.map((row) => rowToTool(row as ConnectionToolRow));
}
Expand Down