Skip to content

UploadTracker - #13579

Open
Dreamsorcerer wants to merge 9 commits into
masterfrom
upload-tracker
Open

UploadTracker#13579
Dreamsorcerer wants to merge 9 commits into
masterfrom
upload-tracker

Conversation

@Dreamsorcerer

@Dreamsorcerer Dreamsorcerer commented Aug 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot labels Aug 29, 2026
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Aug 29, 2026
github-code-quality[bot]
github-code-quality Bot found potential problems Aug 29, 2026
View reviewed changes
Comment thread aiohttp/client.py Fixed
Comment thread tests/test_client_functional.py
await first_chunk_sent.wait()
task.cancel()
with pytest.raises(asyncio.CancelledError):
await task
github-advanced-security[bot]
github-advanced-security Bot found potential problems Aug 29, 2026
View reviewed changes
Comment thread aiohttp/client.py Fixed
Dreamsorcerer
Dreamsorcerer commented Aug 29, 2026
View reviewed changes
Comment thread tests/test_client_functional.py Outdated
Dreamsorcerer
Dreamsorcerer commented Aug 29, 2026
View reviewed changes
Comment thread tests/test_client_functional.py Outdated
@Dreamsorcerer
Apply batched suggestions from code review
f388966 
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
@greptile-apps

greptile-apps Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Reviews (3): Last reviewed commit: "Rename 13427.feature.rst to 13579.featur..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Aug 29, 2026
View reviewed changes
Comment thread aiohttp/http_writer.py
Comment thread aiohttp/client.py
Comment on lines 497 to +500
max_field_size: int | None = None,
max_headers: int | None = None,
middlewares: Sequence[ClientMiddlewareType] | None = None,
upload_tracker: UploadTracker | None = None,

@greptile-apps greptile-apps Bot Aug 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Threat model omits UploadTracker

This adds a public client request option without updating THREAT_MODEL.md, leaving the security model's public API inventory and required audit trail out of sync with the newly exposed upload-observation surface.

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@codecov

codecov Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (20acdf4) to head (74236ef).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #13579      +/-   ##
==========================================
+ Coverage   99.02%   99.03%   +0.01%     
==========================================
  Files         135      135              
  Lines       50500    50940     +440     
  Branches     2652     2678      +26     
==========================================
+ Hits        50007    50448     +441     
  Misses        370      370              
+ Partials      123      122       -1
Flag Coverage Δ
Autobahn 21.93% <13.78%> (-0.10%) ⬇️
CI-GHA 98.92% <100.00%> (+0.01%) ⬆️
OS-Linux 98.70% <100.00%> (+0.01%) ⬆️
OS-Windows 97.11% <100.00%> (+0.02%) ⬆️
OS-macOS 97.98% <100.00%> (+0.01%) ⬆️
Py-3.10 98.11% <98.16%> (-0.01%) ⬇️
Py-3.11 98.36% <100.00%> (+0.01%) ⬆️
Py-3.12 98.44% <100.00%> (+<0.01%) ⬆️
Py-3.13 98.43% <100.00%> (+0.03%) ⬆️
Py-3.14 98.47% <100.00%> (+0.01%) ⬆️
Py-3.14t 97.64% <100.00%> (+0.02%) ⬆️
Py-pypy-3.11 97.41% <100.00%> (+0.01%) ⬆️
VM-macos 97.98% <100.00%> (+0.01%) ⬆️
VM-ubuntu 98.70% <100.00%> (+0.01%) ⬆️
VM-windows 97.11% <100.00%> (+0.02%) ⬆️
cython-coverage 83.31% <96.13%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 96 untouched benchmarks
⏩ 83 skipped benchmarks1

Comparing upload-tracker (74236ef) with master (20acdf4)

Open in CodSpeed

Footnotes

  1. 83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-code-quality[bot]
github-code-quality Bot found potential problems Aug 29, 2026
View reviewed changes
Comment thread tests/test_client_functional.py
assert not fut.done()

body_unblocked.set()
await fut
Dreamsorcerer
Dreamsorcerer commented Aug 29, 2026
View reviewed changes
Comment thread tests/test_client_functional.py Outdated
Dreamsorcerer
Dreamsorcerer commented Aug 29, 2026
View reviewed changes
Comment thread tests/test_client_functional.py Outdated
Dreamsorcerer
Dreamsorcerer commented Aug 29, 2026
View reviewed changes
Comment thread tests/test_client_functional.py Outdated
@Dreamsorcerer

Dreamsorcerer commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

@aiolibsbot review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
+2 more reviewers
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dreamsorcerer @github-advanced-security