Fix flaky benchmark test - #13565
Conversation
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (2): Last reviewed commit: "Fix second flaky benchmark" | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13565 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 135 135
Lines 50454 50494 +40
Branches 2647 2652 +5
=======================================
+ Hits 49961 50001 +40
Misses 370 370
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Merging this PR will improve performance by ×6.2
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_list_element_pattern_redos_payload[whitespace_run_after_content] |
32,426.1 µs | 500.3 µs | ×65 |
| ⚡ | test_list_element_pattern_redos_payload[interleaved_quote_paren_triggers] |
82.9 ms | 32.3 ms | ×2.6 |
| ⚡ | test_read_base64_part |
10.2 ms | 7.2 ms | +41.92% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing flaky-benchmark-test (668da80) with master (c52fe79)2
Footnotes
-
83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
master(88da73a) during the generation of this report, so c52fe79 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Backport to 3.15: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 2677660 on top of patchback/backports/3.15/2677660835e7bfeeb89b8f8c81f1669f6f90f4ed/pr-13565 Backporting merged PR #13565 into master
🤖 @patchback |
No description provided.