Skip to content

Fix flaky benchmark test - #13565

Merged
Dreamsorcerer merged 2 commits into
masterfrom
flaky-benchmark-test
Aug 28, 2026
Merged

Fix flaky benchmark test#13565
Dreamsorcerer merged 2 commits into
masterfrom
flaky-benchmark-test

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot labels Aug 28, 2026
@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (2): Last reviewed commit: "Fix second flaky benchmark" | Re-trigger Greptile

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (4047e5b) to head (668da80).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13565   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         135      135           
  Lines       50454    50494   +40     
  Branches     2647     2652    +5     
=======================================
+ Hits        49961    50001   +40     
  Misses        370      370           
  Partials      123      123           
Flag Coverage Δ
Autobahn 22.03% <33.33%> (-0.01%) ⬇️
CI-GHA 98.91% <91.66%> (-0.01%) ⬇️
OS-Linux 98.68% <91.66%> (-0.01%) ⬇️
OS-Windows 97.08% <91.66%> (+<0.01%) ⬆️
OS-macOS 97.96% <91.66%> (-0.01%) ⬇️
Py-3.10 98.11% <66.66%> (-0.01%) ⬇️
Py-3.11 98.34% <66.66%> (-0.01%) ⬇️
Py-3.12 98.43% <66.66%> (-0.01%) ⬇️
Py-3.13 98.42% <66.66%> (-0.01%) ⬇️
Py-3.14 98.45% <66.66%> (-0.01%) ⬇️
Py-3.14t 97.60% <66.66%> (-0.01%) ⬇️
Py-pypy-3.11 97.39% <66.66%> (-0.03%) ⬇️
VM-macos 97.96% <91.66%> (-0.01%) ⬇️
VM-ubuntu 98.68% <91.66%> (-0.01%) ⬇️
VM-windows 97.08% <91.66%> (+<0.01%) ⬆️
cython-coverage 83.07% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 28, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by ×6.2

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 93 untouched benchmarks
⏩ 83 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
test_list_element_pattern_redos_payload[whitespace_run_after_content] 32,426.1 µs 500.3 µs ×65
test_list_element_pattern_redos_payload[interleaved_quote_paren_triggers] 82.9 ms 32.3 ms ×2.6
test_read_base64_part 10.2 ms 7.2 ms +41.92%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing flaky-benchmark-test (668da80) with master (c52fe79)2

Open in CodSpeed

Footnotes

  1. 83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (88da73a) during the generation of this report, so c52fe79 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Dreamsorcerer
Dreamsorcerer merged commit 2677660 into master Aug 28, 2026
53 checks passed
@Dreamsorcerer
Dreamsorcerer deleted the flaky-benchmark-test branch August 28, 2026 15:32
@patchback

patchback Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Backport to 3.15: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 2677660 on top of patchback/backports/3.15/2677660835e7bfeeb89b8f8c81f1669f6f90f4ed/pr-13565

Backporting merged PR #13565 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.15/2677660835e7bfeeb89b8f8c81f1669f6f90f4ed/pr-13565 upstream/3.15
  4. Now, cherry-pick PR Fix flaky benchmark test #13565 contents into that branch:
    $ git cherry-pick -x 2677660835e7bfeeb89b8f8c81f1669f6f90f4ed
    If it'll yell at you with something like fatal: Commit 2677660835e7bfeeb89b8f8c81f1669f6f90f4ed is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 2677660835e7bfeeb89b8f8c81f1669f6f90f4ed
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix flaky benchmark test #13565 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.15/2677660835e7bfeeb89b8f8c81f1669f6f90f4ed/pr-13565
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer added a commit that referenced this pull request Aug 28, 2026
Dreamsorcerer added a commit that referenced this pull request Aug 28, 2026
…#13577)

**This is a backport of PR #13576 as merged into 3.15
(104220d).**

(cherry picked from commit 2677660)

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant