Migrate to vitest - #963
Conversation
| "jest": "29.7.0", | ||
| "jest-environment-jsdom": "29.7.0", | ||
| "jest-fail-on-console": "3.3.1", |
There was a problem hiding this comment.
| "jest": "29.7.0", | |
| "jest-environment-jsdom": "29.7.0", | |
| "jest-fail-on-console": "3.3.1", |
|
@GeorgeHarland If you can check this one, that'd be really helpful. Lots of things still to fix here, but first issue is that the network requests to the app are failing. |
Co-authored-by: George H <georgeharland12@gmail.com>
Confidence Score: 3/5The PR does not appear safe to merge because the migrated JavaScript suite still has unregistered DOM matchers and an export assertion against a non-mock function. The current Vitest setup never registers the DOM matcher extensions used throughout the tests, and the disabled Files Needing Attention: admin-js/tests/setupTests.jsx and admin-js/tests/simple.test.jsx Reviews (2): Last reviewed commit: "Apply suggestion from @Dreamsorcerer" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| //import failOnConsole from "jest-fail-on-console"; | ||
| import {memoryStore} from "react-admin"; | ||
| import {afterAll, beforeAll, beforeEach, expect} from "vitest"; |
There was a problem hiding this comment.
When the migrated tests evaluate toBeInTheDocument(), the setup no longer imports @testing-library/jest-dom, causing Vitest to reject the unknown matcher and fail the JavaScript test suite.
| jest.mock("react-admin", () => { | ||
| const originalModule = jest.requireActual("react-admin"); | ||
| return { | ||
| ...originalModule, | ||
| downloadCSV: jest.fn(), // Mock downloadCSV to test export button. | ||
| }; | ||
| }); | ||
| });*/ |
There was a problem hiding this comment.
When the export test clicks the Export button, this disabled module mock leaves downloadCSV as the real function, so the subsequent toHaveBeenCalled() and toHaveBeenCalledWith() assertions operate on a non-mock and fail the test.
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
1 participant
No description provided.