fix: encode composite PKs in bulk responses - #1193
Open
8dazo wants to merge 2 commits into
Open
Conversation
updateMany/deleteMany used scalars() and str(id), so compound keys came back as "1" instead of "1|2" and broke react-admin. Fixes aio-libs#1192 Co-authored-by: Cursor <cursoragent@cursor.com>
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (2): Last reviewed commit: "fix: avoid ReturningDelete reassignment ..." | Re-trigger Greptile |
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
==========================================
+ Coverage 95.76% 95.85% +0.08%
==========================================
Files 21 21
Lines 2955 3014 +59
Branches 193 200 +7
==========================================
+ Hits 2830 2889 +59
Misses 100 100
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateMany/deleteManynow return full pipe-joined IDs for composite primary keys ("1|2"), matchinggetList/getOne/getMany.RETURNINGPK column instead ofscalars()(first column only)._convert_idsuses the same"|".join(...)encoding as_convert_record.test_composite_pk_apicovering list, get, update, bulk update, and bulk delete.Fixes #1192
Test plan
pytest tests/test_backends_sqlalchemy.py::test_composite_pk_apitest_update_many,test_delete_many)Made with Cursor