fix(scripts): split rendered declaration in lint_zsh_template - #170
Open
github-actions[bot] wants to merge 1 commit into
Open
fix(scripts): split rendered declaration in lint_zsh_template#170github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Split the local rendered declaration from its assignment in lint_zsh_template() so a failed $(basename ...) command substitution is not masked by local's always-zero exit status. This resolves shellcheck SC2155 without changing the rendered path or lint behavior. Fixes #167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix attempt
This PR was generated by the
droid-issue-fixerGitHub Action, which runsdroid execheadlessly to attempt an open issue.Closes #167
Droid exec summary
Fixed issue #167.
In
scripts/lint-shell-templates.sh, I split thelocal rendereddeclaration from its assignment insidelint_zsh_template():This prevents
local's always-zero exit status from masking a failed$(basename ...)command substitution, resolving shellcheck SC2155. The rendered path and lint behavior are unchanged.I added an in-line comment explaining the SC2155 rationale. Validation passed:
bash -n scripts/lint-shell-templates.shshellcheck --severity=warning -s bash scripts/lint-shell-templates.shCommitted as
fix(scripts): split rendered declaration in lint_zsh_templatewithFixes #167.