Remove registry mirror and ncps from bootstrap#536
Conversation
Test & lint summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the cleanup. The registry mirror and NCPS resources themselves are removed, but the platform outputs now drop many unrelated applications that are still managed by this stack. Please fix the outputs so they remove only registry-mirror and ncps.
|
Addressed Noa's review: restored the unrelated platform app outputs and kept only Validation for this update:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-reviewed the latest changes. The platform outputs are restored and now exclude only registry-mirror and ncps; the previous blocking thread is resolved. I also rechecked the removal references and validation commands relevant to this change.
|
CI is green and Noa approved. Merge is currently blocked by required CODEOWNERS review from agynio/humans. |
Summary
registry-mirrorandncpsArgo CD applications from the platform Terraform stack.registry_mirror_pvc_sizevariable.registry-mirrorin the platform health verification script.Closes #535
Test & lint summary
terraform fmt -recursive -check: passed with no formatting changes needed.terraform -chdir=<stack> init -input=false -backend=false && terraform -chdir=<stack> validateforstacks/apps,stacks/data,stacks/deps,stacks/k8s,stacks/platform,stacks/routing,stacks/system, andstacks/ziti: 8 passed / 0 failed / 0 skipped.bash -n apply.sh .github/scripts/verify_platform_health.sh: passed with no shell syntax errors.terraform -chdir=stacks/platform plan -input=false -lock=false -out=/tmp/platform.tfplan: plan generated platform changes and confirmedplatform_app_namesexcludesregistry-mirrorandncps; command could not complete because local bootstrap had not reached the ziti stack, sodata.terraform_remote_state.zitiwas unavailable../apply.sh -y: attempted locally. Bootstrap was blocked before platform by upstream/local cluster instability unrelated to this change: repeated external image pull TLS timeouts for Argo CD/cert-manager images, then an Argo CD repo-server liveness crash/temporary repo-server connection refusal while applyingstacks/deps.TOTAL_TIMEOUT=30 ./.github/scripts/verify_platform_health.sh: script executed and no longer waited forregistry-mirror; it timed out because the local bootstrap was intentionally incomplete after the abovestacks/depsblockage.