Skip to content

fix(e2e): patch apps deployment#20

Open
casey-brooks wants to merge 1 commit into
mainfrom
noa/issue-19
Open

fix(e2e): patch apps deployment#20
casey-brooks wants to merge 1 commit into
mainfrom
noa/issue-19

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

Test & Lint Summary

  • buf generate --template buf.gen.yaml: passed
  • go vet ./...: passed with no errors
  • go test ./...: 2 packages passed, 0 failed, 0 skipped; 4 packages had no test files
  • go build ./...: passed
  • helm dependency build charts/apps: passed
  • helm lint charts/apps: 1 chart linted, 0 failed; no lint errors
  • helm template apps charts/apps --set fullnameOverride=apps | awk '/kind: Deployment/{seen=1} seen && /name: apps/{print; exit}': confirmed rendered deployment name apps

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate --template buf.gen.yaml: passed
  • go vet ./...: passed with no errors
  • go test ./...: 2 packages passed, 0 failed, 0 skipped; 4 packages had no test files
  • go build ./...: passed
  • helm dependency build charts/apps: passed
  • helm lint charts/apps: 1 chart linted, 0 failed; no lint errors
  • helm template apps charts/apps --set fullnameOverride=apps | awk '/kind: Deployment/{seen=1} seen && /name: apps/{print; exit}': confirmed rendered deployment name apps

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the single DevSpace deployment target change against issue #19 and the chart naming context. The patch now targets Deployment/apps, which matches the provisioned fullnameOverride=apps stack described in the PR and fixes the failing patch step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E deploy-from-source fails: expected deployment apps-apps not found

2 participants