build: add minikube image load support for simple-game-server#4647
Open
markmandel wants to merge 2 commits into
Open
build: add minikube image load support for simple-game-server#4647markmandel wants to merge 2 commits into
markmandel wants to merge 2 commits into
Conversation
Introduce `minikube-push` target in the Makefile to load host-specific Linux images into a specified Minikube profile, tagging them for production use. Add architecture normalization logic for improved compatibility. I found myself loading this into minikube manually a lot for testing, so wanted to make a target to make this easier. Also updated the development documentation on how to use this when testing with the simple-game-server or if it's not published yet. Signed-off-by: Mark Mandel <mark@compoundtheory.com>
Collaborator
|
Build Succeeded 🥳 Build Id: d54e020b-4acd-4672-851e-6883946146a8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
|
||
| # Host machine architecture (amd64/arm64), to match the image tag suffixes | ||
| # above, so we know which arch specific image to load into minikube. | ||
| HOST_ARCH := $(shell dpkg --print-architecture) |
Collaborator
There was a problem hiding this comment.
I'm all good with this, feel free to ignore
I was just thinking if there is OS or something that don't have dpkg ? 🤔
But I'd say, it covers 90% of the use ?
lacroixthomas
approved these changes
Jul 14, 2026
Collaborator
|
Build Failed 😭 Build Id: e4e463bc-cfa2-475d-b332-e821e1d3ab6a Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Introduce
minikube-pushtarget in the Makefile to load host-specific Linux images into a specified Minikube profile, tagging them for production use. Add architecture normalization logic for improved compatibility.I found myself loading this into minikube manually a lot for testing, so wanted to make a target to make this easier.
Also updated the development documentation on how to use this when testing with the simple-game-server or if it's not published yet.
Which issue(s) this PR fixes:
N/A
Did you use AI tools in preparing this PR?:
Y
Special notes for your reviewer:
Just because it needed doing.