Graduate CountsAndLists to Stable: remove feature gate from API valid…#4615
Graduate CountsAndLists to Stable: remove feature gate from API valid…#4615Sivasankaran25 wants to merge 6 commits into
Conversation
github-actions
Bot
added
kind/cleanup
|
Build Failed 😭 Build Id: eba404e9-9236-44fe-bc16-5b434e944ac2 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Failed 😭 Build Id: 86417a25-b0c0-4451-a482-a6acaaf02a6c Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 93e9dd3d-8c4f-4777-8b42-96263f0a6e0a Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 83199d02-dd2c-4bdb-8d9a-a5e198cc2545 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
markmandel
left a comment
markmandel
left a comment
There was a problem hiding this comment.
Wondering if you should update the features.go and the helm chart values at the same time.
| } | ||
| } | ||
|
|
||
| if runtime.FeatureEnabled(runtime.FeatureCountsAndLists) { |
There was a problem hiding this comment.
Looks like you actually removed all the counts and lists logic when it is enabled. Looks like you did it in a few places.
|
Build Failed 😭 Build Id: d74151db-fc69-4246-91eb-433ca236883f Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 8f3fd5dc-83f2-4e4a-9ae7-adb90a4442ee Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Reminder - you pulled out the implementing logic for counts and lists in this PR. You'll need to give it a solid review/rewrite. |
3 participants
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Works On #4590
Did you use AI tools in preparing this PR?:
Y/N
Special notes for your reviewer: