Feat: integrate batch allocator in processor allocator by lacroixthomas · Pull Request #4559 · agones-dev/agones

lacroixthomas · 2026-05-10T21:53:54Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / Why we need it:

Bring the batch allocator improvement from this PR to the processorAllocator feature gate : #4176

Which issue(s) this PR fixes:

Part of #4190 and #3992

Special notes for your reviewer:

agones-bot · 2026-05-10T22:03:42Z

Build Failed 😭

Build Id: c114e430-ff0d-4839-957e-5fd66102b7b0

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2026-05-10T22:17:56Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2026-05-10T22:19:39Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

lacroixthomas · 2026-05-10T22:37:09Z

This is quite a "direct" import of the changes from the original PR, did minor updates on it
Will come back to it to ensure everything is fine in the code itself (might have seen some part that could be updated - improved) and also manually testing it with it all (actual allocations flow etc.)

agones-bot · 2026-05-10T23:19:44Z

Build Failed 😭

Build Id: c50b1a31-0600-48c2-95e8-4face7902b8e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2026-05-12T16:24:05Z

/gcbrun

agones-bot · 2026-05-12T16:51:29Z

Build Failed 😭

Build Id: 4246cd2b-53d1-4624-98df-3b0ca5e6fb97

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2026-05-12T16:59:55Z

/gcbrun

Step #1 - "e2e-feature-gates": Release "agones" does not exist. Installing it now.
Step #1 - "e2e-feature-gates": I0512 16:40:40.497273      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-ping: defaulted unspecified 'cpu' resource for containers [agones-ping] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": I0512 16:40:40.550869      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-extensions: defaulted unspecified 'cpu' resource for containers [agones-extensions] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": I0512 16:40:40.550922      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-controller: defaulted unspecified 'cpu' resource for containers [agones-controller] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": I0512 16:40:40.587701      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-allocator: defaulted unspecified 'cpu' resource for containers [agones-allocator] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": I0512 16:40:40.828318      90 warnings.go:110] "Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies."
Step #1 - "e2e-feature-gates": I0512 16:40:40.867417      90 warnings.go:110] "Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies."
Step #1 - "e2e-feature-gates": I0512 16:50:45.051070      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Job agones-system/agones-delete-agones-resources: defaulted unspecified 'cpu' resource for containers [pre-delete-delete-agones-resources] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": Error: release agones failed, and has been uninstalled due to atomic being set: context deadline exceeded
Step #1 - "e2e-feature-gates": make: *** [Makefile:446: install] Error 1

agones-bot · 2026-05-12T17:57:20Z

Build Succeeded 🥳

Build Id: ff1ca275-3f67-4710-8594-a3dcf6bd472f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.58.0-dev-32c71b9
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.58.0-dev-32c71b9
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.58.0-dev-32c71b9-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.58.0-dev-32c71b9
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.58.0-dev-32c71b9
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.58.0-dev-32c71b9
Linux C++ SDK (build): agonessdk-1.58.0-dev-32c71b9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.58.0-dev-32c71b9.zip

A preview of the website (the last 30 builds are retained):

https://32c71b9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4559/head:pr_4559 && git checkout pr_4559
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.58.0-dev-32c71b9

miai10

Looks good

github-actions · 2026-05-28T22:00:05Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-05-28T22:12:43Z

Build Failed 😭

Build Id: 68ed4e65-1fa3-402d-8035-3e561058d925

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2026-05-28T23:43:06Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-05-28T23:52:37Z

Build Failed 😭

Build Id: d8e3da64-c889-4a5f-a488-91c6d963bd23

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

miai10 · 2026-05-31T20:46:34Z

LGTM!

github-actions · 2026-06-11T22:05:00Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-06-11T23:03:38Z

Build Succeeded 🥳

Build Id: 49b84f77-5e45-46f3-b9bf-5e7a10dc66a9

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.59.0-dev-391e820
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.59.0-dev-391e820
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.59.0-dev-391e820-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.59.0-dev-391e820
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.59.0-dev-391e820
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.59.0-dev-391e820
Linux C++ SDK (build): agonessdk-1.59.0-dev-391e820-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.59.0-dev-391e820.zip

A preview of the website (the last 30 builds are retained):

https://391e820-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4559/head:pr_4559 && git checkout pr_4559
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.59.0-dev-391e820

github-actions · 2026-06-18T22:58:15Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-06-19T00:37:35Z

Build Succeeded 🥳

Build Id: 551a05f8-1a19-4098-9389-1bd9d8fad35f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.59.0-dev-fd67e32
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.59.0-dev-fd67e32
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.59.0-dev-fd67e32-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.59.0-dev-fd67e32
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.59.0-dev-fd67e32
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.59.0-dev-fd67e32
Linux C++ SDK (build): agonessdk-1.59.0-dev-fd67e32-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.59.0-dev-fd67e32.zip

A preview of the website (the last 30 builds are retained):

https://fd67e32-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4559/head:pr_4559 && git checkout pr_4559
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.59.0-dev-fd67e32

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

github-actions · 2026-07-07T21:18:07Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-07-07T21:31:01Z

Build Failed 😭

Build Id: d52a066c-5aed-45fc-a35e-f207dca8a47b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

github-actions · 2026-07-07T21:57:07Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-07-07T22:06:55Z

Build Failed 😭

Build Id: 2f1cd500-b351-4a80-88f2-a0963b5a53c1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2026-07-07T22:08:24Z

/gcbrun

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

github-actions · 2026-07-07T22:15:01Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-07-07T22:25:55Z

Build Failed 😭

Build Id: ecd49a81-249e-42c3-a66e-3c2319bcea12

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

github-actions · 2026-07-07T22:37:46Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-07-07T22:48:24Z

Build Failed 😭

Build Id: d246536c-b23a-42fd-9e92-9d61c8e4526e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

github-actions · 2026-07-07T23:01:23Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-07-07T23:31:08Z

Build Failed 😭

Build Id: 2ae33ff8-fe72-4e3a-9939-6547fd1434a1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2026-07-07T23:34:28Z

/gcbrun

agones-bot · 2026-07-08T00:35:32Z

Build Succeeded 🥳

Build Id: a7f42097-7e72-41fa-976a-0608c252904d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.60.0-dev-1964895
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.60.0-dev-1964895
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.60.0-dev-1964895-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.60.0-dev-1964895
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.60.0-dev-1964895
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.60.0-dev-1964895
Linux C++ SDK (build): agonessdk-1.60.0-dev-1964895-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.60.0-dev-1964895.zip

A preview of the website (the last 30 builds are retained):

https://1964895-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4559/head:pr_4559 && git checkout pr_4559
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.60.0-dev-1964895

…locator

github-actions · 2026-07-14T02:17:46Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

markmandel

Some thoughts for you!

markmandel · 2026-07-14T02:27:34Z

 							c.allocationCache.AddGameServer(gs)
 						}
-						res.err = ErrGameServerUpdateConflict
+						res.err = goErrors.Join(ErrGameServerUpdateConflict, err)


golang native error management is slipping through.

Might be time to really commit to #4510

markmandel · 2026-07-14T02:29:12Z

+			if applyErr == nil {
+				if alreadyAllocated {
+					existingBatch.responses = append(existingBatch.responses, response{request: req, gs: gsToReorder.DeepCopy(), err: nil})
+					existingBatch.counterErrors = goErrors.Join(existingBatch.counterErrors, counterErrors)


More native go error handling slipping though.

markmandel · 2026-07-14T03:03:04Z

+						var propagatedErr error
+						updatedGs, updateErr := c.gameServerGetter.GameServers(lastGsState.ObjectMeta.Namespace).Update(ctx, lastGsState, metav1.UpdateOptions{})
+						if updateErr != nil {
+							c.allocationCache.AddGameServer(lastGsState)


If the erorr is a conflict, we shouldn't put it back in the cache, as the data will be stale.

markmandel · 2026-07-14T03:04:59Z

+	case goErrors.Is(err, ErrConflictInGameServerSelection):
+		gsa.Status.State = allocationv1.GameServerAllocationContention
+		return gsa, nil
+	case goErrors.Is(err, ErrGameServerUpdateConflict):


More modern go error library slipping through.

markmandel · 2026-07-14T03:05:41Z

+						updatedGs, updateErr := c.gameServerGetter.GameServers(lastGsState.ObjectMeta.Namespace).Update(ctx, lastGsState, metav1.UpdateOptions{})
+						if updateErr != nil {
+							c.allocationCache.AddGameServer(lastGsState)
+							propagatedErr = goErrors.Join(ErrGameServerUpdateConflict, updateErr)


Shouldn't this only be a Conflict error, on an actual conflict?

markmandel · 2026-07-14T03:20:37Z

+			}
+
+		case <-ctx.Done():
+			flush()


Not sure I understand why we're flushing when we are shutting down -- would this lock up, as it's pushing into channels that don't have any workers to receive?

markmandel · 2026-07-14T03:21:58Z

 		switch {
 		case err == nil:
 			return true, nil
-		case err == ErrNoGameServer:


Should this be removed?

markmandel · 2026-07-14T03:23:34Z

+		gsToReorderIndex int
+		want             []*agonesv1.GameServer
+	}{
+		"pakced (no change)": {


packed 😄

markmandel · 2026-07-14T03:25:29Z

+			return
+
+		default:
+			flush()


Nit: flush will recreate a new map on each pass through - even when there's nothing to process. Would be good to check this either inside or outside of flush()

markmandel · 2026-07-14T03:35:25Z

+				if removeErr := c.allocationCache.RemoveGameServer(foundGs); removeErr != nil {
+					removeErr = errors.Wrap(removeErr, "error removing gameserver from cache")
+					req.response <- response{request: req, gs: nil, err: removeErr}
+					list = append(list[:foundGsIndex], list[foundGsIndex+1:]...)


If this fails, is the index now wrong? since the list has changed size?

agones-bot · 2026-07-14T04:01:10Z

Build Succeeded 🥳

Build Id: dee469f2-222e-4a45-b738-6b1541fbf89f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.60.0-dev-8ef34ef
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.60.0-dev-8ef34ef
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.60.0-dev-8ef34ef-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.60.0-dev-8ef34ef
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.60.0-dev-8ef34ef
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.60.0-dev-8ef34ef
Linux C++ SDK (build): agonessdk-1.60.0-dev-8ef34ef-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.60.0-dev-8ef34ef.zip

A preview of the website (the last 30 builds are retained):

https://8ef34ef-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4559/head:pr_4559 && git checkout pr_4559
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.60.0-dev-8ef34ef

github-actions Bot added kind/feature New features for Agones size/L labels May 10, 2026

github-actions Bot added the size/XL label May 10, 2026

miai10 suggested changes May 17, 2026

View reviewed changes

Comment thread pkg/gameserverallocations/allocator.go Outdated

lacroixthomas mentioned this pull request Jun 1, 2026

Feat: improve poor sessions packing using batch allocator #4176

Closed

lacroixthomas and others added 4 commits July 7, 2026 17:17

feat: integrate batch allocator in processor allocator

a95278e

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

feat: update / re-add existing unit tests from PR

9bfe5c4

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

feat: fix linter issue

388b773

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

feat: match previous behabiour from previous PR

8bf3c39

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

lacroixthomas force-pushed the features/add-batch-allocator-in-processor-allocator branch from fd67e32 to 8bf3c39 Compare July 7, 2026 21:17

feat: address feedback from orginal PR

b0d4b08

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

feat: remove old FeaturePlayerAllocationFilter unit test

4d67795

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

feat: fix unit tests - feature gates

e6667e0

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

feat: rollback changes and fix rebase conflicts leftover

1964895

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>

lacroixthomas marked this pull request as ready for review July 7, 2026 23:19

lacroixthomas requested a review from a team July 9, 2026 20:52

Merge branch 'main' into features/add-batch-allocator-in-processor-al…

8ef34ef

…locator

markmandel reviewed Jul 14, 2026

View reviewed changes

Uh oh!

Conversation

lacroixthomas commented May 10, 2026

Uh oh!

agones-bot commented May 10, 2026

Uh oh!

github-actions Bot commented May 10, 2026

Uh oh!

github-actions Bot commented May 10, 2026

Uh oh!

lacroixthomas commented May 10, 2026

Uh oh!

agones-bot commented May 10, 2026

Uh oh!

lacroixthomas commented May 12, 2026

Uh oh!

agones-bot commented May 12, 2026

Uh oh!

lacroixthomas commented May 12, 2026

Uh oh!

agones-bot commented May 12, 2026

Uh oh!

miai10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

agones-bot commented May 28, 2026

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

agones-bot commented May 28, 2026

Uh oh!

miai10 commented May 31, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026

Uh oh!

agones-bot commented Jun 11, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

agones-bot commented Jun 19, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

agones-bot commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

agones-bot commented Jul 7, 2026

Uh oh!

lacroixthomas commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

agones-bot commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

agones-bot commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

agones-bot commented Jul 7, 2026

Uh oh!

lacroixthomas commented Jul 7, 2026

Uh oh!

agones-bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment