react-component-layout: one file per region, folders per area, no line limits - #26
Merged
Merged
Conversation
Drop the 60-80 and 15 line limits. A file names one thing on screen and exports one component; parts stay with their region, regions (rows, panels, sections, pickers, anything another file needs) get their own file, and files grouped by kind (Cells, Rows, helpers) are buckets. Also adds the view-model section from the canonical copy. Same text as agoda-com/dropmcp#43.
…low. Add two sections: one folder per area under components/, shared components at the top (no shared/ or common/), a sub-folder only for a region with its own family, two levels at most, no one-file folders, folders named after the screen; and keep the component tree shallow by composing at the parent instead of chaining pass-through wrappers.
joeldickson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
react-component-layoutto replace line-count rules with structural ones.Cells.tsx,helpers.tsx).components/; shared components at the top (noshared/orcommon/); a sub-folder only for a region with its own family; two levels at most; no one-file folders; folders named after the screen.Same text as agoda-com/dropmcp#43, where it is applied to the client. Docs-only change to the skill file.