Release 2.8.0: the wallet screen fails closed when it cannot confirm an approval - #125
Merged
Conversation
…an approval Minor rather than patch because runtime behavior changes. Both wallet-OFAC paths branched on decision == "deny", so everything that was not literally that string was permitted by structure, including a null decision from an unreadable response. On the compute-first path that would have settled the payment. Both now deny unless the decision is exactly "allow". No exported surface changes, so nothing to migrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version bump for the fail-closed change merged in #124.
Minor rather than patch, because runtime behavior changes. Both wallet-OFAC paths branched on
decision == "deny", so everything that was not literally that string was permitted by structure, including a null decision from an unreadable response. On the compute-first path that would have settled the payment.Type of change
The bump itself is maintenance; the behavior it releases landed in #124 and is classified there.
Public API
No signature, model or response shape changes.
Behavior changes for two response shapes that should not occur against a current API: an assess response with no
decision, and one carrying an unrecognised decision value. Both now deny where they previously allowed, returningapi_errorandwallet_not_trustedrespectively. Nothing to migrate.Test plan
On the bumped tree:
uv run ruff check,uv run ruff format --checkanduv run ty checkall clean;uv run pytestgives 1868 passed, 4 skipped, coverage 95.37% against the 95% gate.The behavior itself is verified in #124, including a drill that restores the original
decision == "deny"check in both files and confirms five tests fail.Checklist