-
Notifications
You must be signed in to change notification settings - Fork 797
fix: skip compressed assistant tool calls #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guslegend0510
wants to merge
7
commits into
agentscope-ai:main
Choose a base branch
from
guslegend0510:fix/issue-1482-autocontext-loop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9a3af0e
fix: skip compressed assistant tool calls
guslegend 45885e6
test(core): improve MessageUtils patch coverage
guslegend bde1796
Merge branch 'main' into fix/issue-1482-autocontext-loop
guslegend0510 5ae72f1
Merge branch 'main' into fix/issue-1482-autocontext-loop
LearningGp 3edeece
Merge branch 'main' into fix/issue-1482-autocontext-loop
guslegend0510 ae17ebc
ci: retrigger license check
guslegend 6f1b2c3
fix(core): avoid stale tool calls after compression
guslegend File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 133 additions & 0 deletions
133
agentscope-core/src/test/java/io/agentscope/core/util/MessageUtilsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| /* | ||
| * Copyright 2024-2026 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.agentscope.core.util; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import io.agentscope.core.message.Msg; | ||
| import io.agentscope.core.message.MsgRole; | ||
| import io.agentscope.core.message.TextBlock; | ||
| import io.agentscope.core.message.ToolUseBlock; | ||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import org.junit.jupiter.api.DisplayName; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| @DisplayName("MessageUtils Tests") | ||
| class MessageUtilsTest { | ||
|
|
||
| @Test | ||
| @DisplayName("Should skip compressed assistant messages when extracting recent tool calls") | ||
| void testExtractRecentToolCallsSkipsCompressedAssistantMessages() { | ||
| List<Msg> messages = new ArrayList<>(); | ||
| messages.add(createAssistantToolUseMessage("real-tool", "real-call")); | ||
| messages.add(createCompressedAssistantToolUseMessage("compressed-tool", "compressed-call")); | ||
|
|
||
| List<ToolUseBlock> toolCalls = MessageUtils.extractRecentToolCalls(messages, "assistant"); | ||
|
guslegend0510 marked this conversation as resolved.
|
||
|
|
||
| assertEquals(1, toolCalls.size()); | ||
| assertEquals("real-tool", toolCalls.get(0).getName()); | ||
| assertEquals("real-call", toolCalls.get(0).getId()); | ||
| assertFalse(toolCalls.stream().anyMatch(block -> "compressed-call".equals(block.getId()))); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName( | ||
| "Should return empty list when the latest assistant segment only contains compressed" | ||
| + " messages") | ||
| void testExtractRecentToolCallsReturnsEmptyWhenLatestAssistantSegmentIsFullyCompressed() { | ||
| List<Msg> messages = new ArrayList<>(); | ||
| messages.add(createAssistantToolUseMessage("stale-tool", "stale-call")); | ||
| messages.add(createUserMessage("continue")); | ||
| messages.add(createCompressedAssistantToolUseMessage("compressed-tool", "compressed-call")); | ||
|
|
||
| List<ToolUseBlock> toolCalls = MessageUtils.extractRecentToolCalls(messages, "assistant"); | ||
|
|
||
| assertTrue(toolCalls.isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("Should return empty list when messages are null or empty") | ||
| void testExtractRecentToolCallsWithEmptyInput() { | ||
| assertTrue(MessageUtils.extractRecentToolCalls(null, "assistant").isEmpty()); | ||
| assertTrue(MessageUtils.extractRecentToolCalls(List.of(), "assistant").isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("Should not skip assistant messages when _compress_meta is not a map") | ||
| void testExtractRecentToolCallsDoesNotSkipAssistantMessagesWithInvalidCompressMetadata() { | ||
| Msg message = | ||
| createAssistantToolUseMessage( | ||
| "real-tool", "real-call", Map.of("_compress_meta", "not-a-map")); | ||
|
|
||
| List<ToolUseBlock> toolCalls = | ||
| MessageUtils.extractRecentToolCalls(List.of(message), "assistant"); | ||
|
|
||
| assertEquals(1, toolCalls.size()); | ||
| assertEquals("real-call", toolCalls.get(0).getId()); | ||
| } | ||
|
|
||
| private Msg createAssistantToolUseMessage(String toolName, String callId) { | ||
| return createAssistantToolUseMessage(toolName, callId, Map.of()); | ||
| } | ||
|
|
||
| private Msg createAssistantToolUseMessage( | ||
| String toolName, String callId, Map<String, Object> metadata) { | ||
| return Msg.builder() | ||
| .role(MsgRole.ASSISTANT) | ||
| .name("assistant") | ||
| .content( | ||
| List.of( | ||
| ToolUseBlock.builder() | ||
| .name(toolName) | ||
| .id(callId) | ||
| .input(new HashMap<>()) | ||
| .build())) | ||
| .metadata(metadata) | ||
| .build(); | ||
| } | ||
|
|
||
| private Msg createCompressedAssistantToolUseMessage(String toolName, String callId) { | ||
| Map<String, Object> metadata = new HashMap<>(); | ||
| metadata.put("_compress_meta", Map.of("offloaduuid", "uuid-123")); | ||
|
|
||
| return Msg.builder() | ||
| .role(MsgRole.ASSISTANT) | ||
| .name("assistant") | ||
| .content( | ||
| List.of( | ||
| ToolUseBlock.builder() | ||
| .name(toolName) | ||
| .id(callId) | ||
| .input(new HashMap<>()) | ||
| .build(), | ||
| TextBlock.builder().text("Compressed summary").build())) | ||
| .metadata(metadata) | ||
| .build(); | ||
| } | ||
|
|
||
| private Msg createUserMessage(String text) { | ||
| return Msg.builder() | ||
| .role(MsgRole.USER) | ||
| .name("user") | ||
| .content(List.of(TextBlock.builder().text(text).build())) | ||
| .build(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.