fix(agent): 对齐 EventType.ALL 的文档与流式行为#1463
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
LearningGp
left a comment
There was a problem hiding this comment.
If we confirm that the AGENT_RESULT event should be included in ALL, the Javadoc for AGENT_RESULT itself should also be updated accordingly.
PTAL @chickenlj
a199153 to
0ea0c3b
Compare
|
@LearningGp 麻烦审核,一下,谢谢 |
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR correctly updates the AGENT_RESULT Javadoc to reflect that it is streamed by default (because StreamOptions defaults use EventType.ALL and shouldStream() returns true for any type when ALL is present). However, the fix is incomplete: the ALL constant's own Javadoc at line 97 still says "Special value to stream all event types (except AGENT_RESULT)" — the exact same misinformation this PR aims to correct. Additionally, the PR description claims to update English/Chinese streaming docs and add regression tests, but neither appears in the diff. The streaming docs (docs/v1/en/docs/task/streaming.md lines 46-47 and docs/v1/zh/docs/task/streaming.md lines 46-47) still state AGENT_RESULT is "not included in stream by default" and ALL means "all the above (except AGENT_RESULT)". Please fix these remaining inconsistencies so the documentation alignment is complete.
做了什么
EventType.ALL和StreamOptions#getEventTypes()实际会包含AGENT_RESULTEventType.ALL会流式输出AGENT_RESULT原因
验证
mvn -pl agentscope-core spotless:applymvn -pl agentscope-core -Dtest=StreamOptionsTest testFixes #1439