fix(controller): prevent Team auto-reconciliation after explicit deletion (#1143) - #1144
Conversation
…tion (issue agentscope-ai#1143) When a Team is deleted via the REST API (e.g. ), the reconciler would automatically re-create it within seconds because the delete request was not distinguished from normal failure recovery. Add AnnotationTeamDeleteRequested to signal intentional deletion. The reconciler skips normal reconciliation once this annotation is set and the finalizer has been removed, preventing unwanted auto-recovery. Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
|
Thanks for the contribution. I reproduced #1143 locally on v1.2.0 and confirmed that the Team was never recreated: the UID stayed unchanged, while The annotation guard in this PR runs only after the existing 感谢贡献。我在本地 v1.2.0 环境复现了 #1143,并确认 Team 从未被重新创建:删除前后 UID 保持不变,Controller 因 Tuwunel 返回 本 PR 的 annotation guard 位于现有 |
Fixes #1143
问题
删除 Team 后,reconciler 在 2 秒内自动恢复 Team。
修复方案
agentteams.io/delete-requested标记用户主动请求删除变更文件
AnnotationTeamDeleteRequested测试
全部单元测试通过,无回归。
Fixes #1143
Question
After deleting Team, reconciler automatically restores Team within 2 seconds.
Repair plan
agentteams.io/delete-requestedto mark the user actively requesting deletionChange files
AnnotationTeamDeleteRequestedTest
All unit tests passed, no regression.