Repository navigation
fix(auth): Create account button silently did nothing on invalid input - #31
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df7ba8d:
|
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The server-side sign-up works. On production (46d66baf) a real test sign-up returned
303 → /chat,wrangler tailshowedevent: registered, and the test account was deleted afterwards. The problem is on the client:/loginrelied on the browser's native constraint validation (required,type=email,minLength=10). When the email was invalid or the password was under 10 characters, the browser blocked the submit and showed only a native bubble:No request is sent, so clicking "สร้างบัญชี DevStack" looks like it does nothing. In headless Chromium (iPhone 13, Pixel 7 and desktop), short-password and empty submits sent 0 requests and only set
validationMessage.Ruled out:
form-action 'self'covers the POST./api/authis a known prefix.Fix
noValidate, plus a client check that mirrors the server rules (valid email, password 10–200 characters).role=alertmessage, and focus moves to the field with the problem.pendingresets on bfcachepageshow.Tests
tests/login-form.test.tsx: 4 of its 5 tests fail on the old component.Not caused by today's deploys:
login-form.tsxand the password route are unchanged since before f5c15746, so a rollback would not help. Not deployed.