Enforce verifier-owned SNP platform policy - #656
Merged
Merged
Conversation
Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
imran-siddique
marked this pull request as ready for review
September 17, 2026 22:56
imran-siddique
requested review from
a team,
carloshvp,
qubeena07 and
zohebk8s
as code owners
September 17, 2026 22:56
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add immutable
SnpPlatformPolicyrequirements to native SNP, Azure vTPM-rooted SNP and the publicverify_trace_claimAPI. Explicit policy requires authenticated SNP evidence and is evaluated only after signature/chain verification.Why
A valid report signature establishes authenticity but does not establish that the reported platform meets the relying party's requirements. Callers can now require or forbid PLATFORM_INFO fields, reject unknown bits, and receive a failure when software evidence or another provider cannot satisfy the configured SNP policy.
Security impact
Policy is supplied by the verifier, not accepted from the claim issuer. Unknown or contradictory field requirements are rejected. Omitting the optional policy preserves existing verification behavior.
This covers PLATFORM_INFO only. Guest DEBUG policy, firmware TCB currency, revocation, GPU state and runtime gateway admission remain outside this change. Synthetic signed reports test enforcement; this PR does not claim a new cMCP hardware run.
Test plan
pytest tests/unit tests/conformance tests/integration -q: 1,871 passed, 8 skipped on Windows/Python 3.12ruff check src/ tests/mypy src/cmcp_runtime/ src/cmcp_verify/bandit -q -r src/ -c pyproject.tomlIncludes 28 focused platform-policy tests using signed synthetic evidence, covering both SNP paths, the public API and provider/software bypass attempts. Checks ran on the branch rebased onto current main with matching local package metadata.
DCO sign-off