fix(deps): replace vulnerable xlsx release - #660
Open
alexandroit wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AgentLang uses
xlsxinsrc/api/http.tsto generate evaluation workbooks. The npmxlsx@0.18.5release is affected by GHSA-4r6h-8v6p-xvw6 (prototype pollution) and GHSA-5pgg-2g8v-p4x9 (ReDoS).This changes only the dependency resolution:
The package remains available as
xlsx, so the existingimport * as XLSX from 'xlsx'and workbook export code do not change.@stackline/xlsxis an independent, maintained SheetJS-compatible fork with regression tests for both advisories. It requires Node 20+, which matches AgentLang'snode >=20.0.0contract.Disclosure: I maintain the Stackline fork. A neutral alternative is SheetJS CE 0.20.3 from the official tarball.
Validation
pnpm install --frozen-lockfile --ignore-scriptspnpm test: 429 passedpnpm build: passedpnpm lint: passed with one pre-existing generated-file warning__proto__/constructorworksheet headers: noObject.prototypepollutionpnpm why xlsx: resolvesxlsx <- @stackline/xlsx@1.0.6Only
package.jsonandpnpm-lock.yamlare changed.