pkg/provider: live RDS and CloudWatch SDK adapters - #45
Merged
Merged
Conversation
pkg/rds shipped a complete read-only collector whose only missing piece was the translation between an AWS SDK struct and a struct with the same field names. Adds service/rds and service/cloudwatch to go.mod and writes that translation across seven read operations, recording every decision about what an unset SDK field means -- five of which change what a report says. Tests fake the SDK client: no credential, no ~/.aws, no AWS_* and no socket. Co-authored-by: kording <74226694+kording@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
게이트 5축 ALL GREEN(go mod tidy 후 재검증). 부정행위 3점 검사 통과. 이 웨이브에서 go.mod/go.sum 을 만지는 유일 잡.