cmd, pkg/domain: wire rds, backtest and explain into the binary - #41
Merged
Merged
Conversation
The three packages merged earlier today all deferred their wiring, so a user building today could not reach any of them. This closes that gap: pkg/domain learns the rds kind, and cmd/kilter gains rds, backtest and explain subcommands. The backtest live path refuses honestly, because pkg/store keeps only the latest snapshot and has no history to replay. Closes a real hole found on the way: the account-wide commitment baseline accepted domain-supplied usage lines unchecked, so an empty ID double-counted, a duplicate ID overwrote another domain's line, and a zero rate priced real usage at nothing — all three overstate absorption and therefore savings. Invalid lines are now dropped with a warning, and a control test proves this is a no-op for every shipped domain. Also fixes a renderer that printed the oracle gap at 100x because Scorecard.OracleGapPct is already scaled while its doc comment says otherwise. The two test-fixture updates are forced, not loosened: five tests used the literal "rds" as their stand-in for an unknown kind, which it no longer is, and one asserted the number of wired domains. Every assertion is unchanged. Co-authored-by: kording <74226694+kording@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate 5-axis ALL GREEN. Closes the reachability debt from today's three merges. Also closes an unchecked-usage-line hole in the account-wide commitment baseline that overstated savings, and a 100x oracle-gap display bug. The two test-fixture updates are forced by the rds kind becoming valid - every assertion is unchanged. go.sum byte-identical.