Declare native_ask so an interactive step_up becomes a terminal prompt (0.17.0) - #34
Merged
Merged
Conversation
The gateway may now answer a step_up with decision "ask" when the harness says it can render a permission dialog. Claude Code declares the capability on PreToolUse; Codex (deny-only parser) declares none. The existing ask() path renders it; the model-facing steer tells the agent not to retry the same command after a no. Bumps to 0.17.0 in all three version sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declares
capabilities: ["native_ask"]on PreToolUse so the gateway may answer an interactivestep_upwithdecision: "ask"— Claude Code then shows its own permission prompt instead of the agent hitting a deny + console link. The existingask()path renders it; the model‑facing steer now says a human is being asked in this terminal and not to retry the same command after a no.Codex declares no capability: its parser acts only on
deny, so anaskthere would fail the hook run and let the call through unreviewed.Nothing is sent on PostToolUse. Version 0.17.0 in all three sites.
Tests
node --test test/*.test.mjs→ 192 passed. Newtest/native-ask.test.mjs: capability present for Claude Code, absent for Codex,askverdict →permissionDecision: "ask"with[ACP] Approval required:on both channels, same verdict under Codex →deny, PostToolUse carries nocapabilities.Pairs with
gatewaystack-connect
feat/terminal-enforce(rollout keyharness_ask, internal). Merge the gateway first; against an old gateway this plugin behaves exactly as 0.16.0.