Skip to content

feat(web): group Authorize repository's GitHub picker by account - #2511

Merged
zfy0701 merged 1 commit into
mainfrom
claude/picker-group-by-account
Sep 26, 2026
Merged

zfy0701 merged 1 commit into
mainfrom
claude/picker-group-by-account

Conversation

@zfy0701

@zfy0701 zfy0701 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Part of #2398. #2509 added whole installations to Authorize repository's GitHub picker, but the list was flat: every account's "All repositories in <account>" at the top, then every repository from every account mixed together. The picker now groups by account.

Changes

  • AddAgentRepoModal.tsx: the GitHub picker renders one group per account, in the order of the organization's installations. An account with no installation comes after them, alphabetically.
    • Each group has a caps header with the account name.
    • The group starts with that account's "All repositories in <account>" choice, when the installation can still be granted, followed by the account's repositories.
    • Search filters the installation choices by account name and the repositories by full name, as before, and a group left empty is hidden.
    • The installation and repository rows are unchanged; they moved into two render helpers.
  • agent-multi-repo-authorization.md: the Web section describes the grouped picker.

Tests

  • New case in EditWorkspaceModal.installations.test.tsx: two accounts, one already granted. The groups come out in installation order, and each lists the installation choice, if still grantable, before its repositories.
  • pnpm --dir packages/web exec vitest run --maxWorkers=2 src/components/console/modals/ src/components/console/WorkspaceCard.test.tsx: 25 files, 207 tests passed.
  • pnpm --filter @agentconnect.md/web typecheck passes, and prettier and eslint are clean on the changed files.

🤖 Generated with Claude Code . Opus 5.5

With whole installations offered beside repositories, the picker was one
flat list: every account's "All repositories" choice on top, then every
repository from every account. It now groups by account, in installation
order: each group is headed by the account, opens with that account's
"All repositories" choice when it can still be granted, and then lists
the account's repositories. Search still filters both.

Part of #2398.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zfy0701
zfy0701 enabled auto-merge (squash) September 25, 2026 21:34

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The account grouping preserves the picker’s existing search and selection behavior, and I found no blocking issue in this PR. git diff --check passed. Web tests and typecheck could not run here because dependencies and pnpm are unavailable.

sent by review-bot (Codex · gpt-6-sol) · open in session

@agentconnect-md-test

Copy link
Copy Markdown
Contributor

The code review still passes at 74b843f, with no blocking findings. The formal approval for this rerun was not submitted: submitCodeReview returned a GitHub response parsing error twice. A read-only check shows the earlier approval at the same commit, but no new review for this rerun.

sent by review-bot (Codex · gpt-6-sol) · open in session

@agentconnect-md-test

Copy link
Copy Markdown
Contributor

unexpected status 401 Unauthorized: Incorrect API key provided: sk-svcac***********************************************************************************************************************************************************fvMA. You can find your API key at https://platform.openai.com/account/api-keys., url: https://chatgpt.com/backend-api/codex/responses, cf-ray: a40db0681b50ec9c-SEA, request id: 80b9d93c-9295-4dd3-b79d-78be2ff3b57e

sent by review-bot (Codex · gpt-6-sol) · open in session

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 74b843f. This review generation targets the same verified revision reviewed earlier. The account grouping preserves the picker’s existing search and selection behavior, and I found no blocking regression. Web tests and typecheck could not run in this checkout because dependencies and pnpm are unavailable.

sent by review-bot (Codex · gpt-6-sol) · open in session

@zfy0701
zfy0701 merged commit 134e29f into main Sep 26, 2026
13 checks passed
@zfy0701
zfy0701 deleted the claude/picker-group-by-account branch September 26, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant