fix(web): say why By decision is unavailable, not only that it is - #2507
Merged
Merged
Conversation
By decision's tooltip read "No Decision provider is ready where this agent runs" whatever the cause, so an organization with no provider key could not tell that adding one in Infra was the fix. The block now names the most fixable reason among the providers where the agent runs: a missing key, a daemon too old for Decisions, or an offline daemon, and keeps the general message for anything else. Part of #2398. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zfy0701
enabled auto-merge (squash)
September 25, 2026 12:41
Contributor
There was a problem hiding this comment.
Approved. The new By decision tooltips use the provider catalog's readiness states after filtering to the agent's placement and selector-capable models, and the existing ready-provider and missing-selector behavior remains intact. I found no blocking regression. git diff --check passed. I could not rerun the focused test in this checkout because dependencies are not installed; the PR reports 218 passing tests.
sent by review-bot (Codex · gpt-6-sol) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2398. When By decision is unavailable, its tooltip always read "No Decision provider is ready where this agent runs". An organization with no provider key had no way to tell that adding one in Infra → Provider keys was the fix, because AgentConnect credits serve only AgentConnect Cloud.
Changes
lib/repository-selector.ts:repositoryDecisionBlocknames the most fixable reason among the selector-capable providers on the daemon, group or pool that runs the agent. In order of precedence:credentials, a missing provider key;outdated, a daemon without Decision support;offline, an offline daemon.Anything else, including no provider at all, stays the general
providerblock.selectoris unchanged.WorkspaceFormFields.tsx: each block has its own tooltip.en: "Add a Decision provider key in Infra first", "Update the daemon that runs this agent to use Decisions", "The daemon that runs this agent is offline".
zh-CN: equivalents of the three strings above.
Tests
pnpm --dir packages/web exec vitest run --maxWorkers=2 src/lib/repository-selector.test.ts src/components/console/modals/ src/components/console/WorkspaceCard.test.tsx src/components/console/WorkspaceFormFields.test.tsx src/i18n/locale.test.ts: 27 files, 218 tests passed.repository-selector.test.tscovers each reason and the precedence: a missing key is named over an offline daemon.pnpm --filter @agentconnect.md/web typecheckpasses, and prettier is clean on the changed files.🤖 Generated with Claude Code . Opus 5.5