Skip to content

fix(web): say why By decision is unavailable, not only that it is - #2507

Merged
zfy0701 merged 1 commit into
mainfrom
claude/decision-block-reason
Sep 25, 2026
Merged

zfy0701 merged 1 commit into
mainfrom
claude/decision-block-reason

Conversation

@zfy0701

@zfy0701 zfy0701 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Part of #2398. When By decision is unavailable, its tooltip always read "No Decision provider is ready where this agent runs". An organization with no provider key had no way to tell that adding one in Infra → Provider keys was the fix, because AgentConnect credits serve only AgentConnect Cloud.

Changes

  • lib/repository-selector.ts: repositoryDecisionBlock names the most fixable reason among the selector-capable providers on the daemon, group or pool that runs the agent. In order of precedence:

    1. credentials, a missing provider key;
    2. outdated, a daemon without Decision support;
    3. offline, an offline daemon.

    Anything else, including no provider at all, stays the general provider block. selector is unchanged.

  • WorkspaceFormFields.tsx: each block has its own tooltip.

  • en: "Add a Decision provider key in Infra first", "Update the daemon that runs this agent to use Decisions", "The daemon that runs this agent is offline".

  • zh-CN: equivalents of the three strings above.

Tests

  • pnpm --dir packages/web exec vitest run --maxWorkers=2 src/lib/repository-selector.test.ts src/components/console/modals/ src/components/console/WorkspaceCard.test.tsx src/components/console/WorkspaceFormFields.test.tsx src/i18n/locale.test.ts: 27 files, 218 tests passed.
    • repository-selector.test.ts covers each reason and the precedence: a missing key is named over an offline daemon.
    • The Edit workspace case with a missing-key provider now expects the key tooltip.
  • pnpm --filter @agentconnect.md/web typecheck passes, and prettier is clean on the changed files.

🤖 Generated with Claude Code . Opus 5.5

By decision's tooltip read "No Decision provider is ready where this
agent runs" whatever the cause, so an organization with no provider key
could not tell that adding one in Infra was the fix. The block now names
the most fixable reason among the providers where the agent runs: a
missing key, a daemon too old for Decisions, or an offline daemon, and
keeps the general message for anything else.

Part of #2398.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zfy0701
zfy0701 enabled auto-merge (squash) September 25, 2026 12:41

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The new By decision tooltips use the provider catalog's readiness states after filtering to the agent's placement and selector-capable models, and the existing ready-provider and missing-selector behavior remains intact. I found no blocking regression. git diff --check passed. I could not rerun the focused test in this checkout because dependencies are not installed; the PR reports 218 passing tests.

sent by review-bot (Codex · gpt-6-sol) · open in session

@zfy0701
zfy0701 merged commit 6679bfc into main Sep 25, 2026
13 checks passed
@zfy0701
zfy0701 deleted the claude/decision-block-reason branch September 25, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant