Handle partial volume creation failures during CreateActor.#527
Open
Michelle Au (msau42) wants to merge 1 commit into
Open
Handle partial volume creation failures during CreateActor.#527Michelle Au (msau42) wants to merge 1 commit into
Michelle Au (msau42) wants to merge 1 commit into
Conversation
Michelle Au (msau42)
force-pushed
the
handle-create-volume-failure
branch
2 times, most recently
from
July 24, 2026 23:20
15bbd60 to
05542ff
Compare
1. Adds a new CREATING status that gets persisted before we start to create volumes. Only when all volumes are successfully created the Actor status transitions to SUSPENDED. Currently CreateActor is not idempotent. If volume creation fails, the actor has to be deleted, which will also delete any partially created volumes. 2. Changes volume id to use actor uid instead of atespace+actorname, and add "substrate" prefix 3. Adds a new DELETING status that gets persisted before we start to delete volumes. This shifts the existing DB DELETE precondition checks to the new DELETING status. And now you can only delete the actor in DB from DELETING status. In the future, we will also add a workflow that will do mandatory node cleanup of volumes before starting to delete the volumes.
Michelle Au (msau42)
force-pushed
the
handle-create-volume-failure
branch
from
July 24, 2026 23:45
05542ff to
7878a0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #232
Currently CreateActor is not idempotent. If volume creation fails, the actor has to be deleted, which will also delete any partially created volumes.
Changes volume id to use actor uid instead of atespace+actorname and adds "substrate" prefix
Adds a new DELETING status that gets persisted before we start to delete volumes.
This shifts the existing DB DELETE precondition checks to the new DELETING status. And now you can only delete the actor in DB from DELETING status.
In the future, we will also add a workflow that will do mandatory node cleanup of volumes before starting to delete the volumes.