Fix orphaned golden actors by using deterministic actor IDs in ActorTemplateReconciler#526
Open
Troy Chiu (troychiu) wants to merge 1 commit into
Open
Conversation
…TemplateReconciler`
Troy Chiu (troychiu)
force-pushed
the
fix-orphaned-golden-actors
branch
from
July 24, 2026 21:37
d81b4cb to
0944556
Compare
| switch at.Status.Phase { | ||
| case atev1alpha1.PhaseInitial: | ||
| actorID := uuid.NewString() | ||
| actorName := string(at.UID) |
Contributor
Author
There was a problem hiding this comment.
Kubernetes UIDs (https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#uids) should be compatible with resource names, which are enforced by standard RFC-1123 DNS label rules.
Eitan Yarmush (EItanya)
approved these changes
Jul 24, 2026
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
Collaborator
There was a problem hiding this comment.
Great catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where reconciliation retries in
PhaseInitialleft orphaned actors inateapiwhenCreateActorsucceeded but status update failed.Fixes #525