demo(counter): capture process memory on suspend (onCommit: Full)#521
Closed
Gabor Pikats (mcftira) wants to merge 1 commit into
Closed
demo(counter): capture process memory on suspend (onCommit: Full)#521Gabor Pikats (mcftira) wants to merge 1 commit into
Gabor Pikats (mcftira) wants to merge 1 commit into
Conversation
The demo promises state preservation across suspend/resume, but shipped onCommit: Data, so suspend checkpoints took the runsc fscheckpoint branch (filesystem only) and process memory was never captured. Actors cold-booted on resume and the demo's own preserved-memory counter reset every time. With onCommit: Full, suspend captures a full runsc checkpoint (memory + fs) and resume restores it via runsc restore. Fixes agent-substrate#519
Author
|
All yours 😄 Closing as dupe of #520. FWIW I verified the same fix end-to-end on kind - memory counter continues across suspend/resume - so consider this an independent confirmation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #519
The counter demo promises state preservation across suspend/resume, but shipped
onCommit: Data- so suspend checkpoints took therunsc fscheckpointbranch (filesystem only) and process memory was never captured. On resume, actors cold-booted with only the DurableDir restored: the demo's ownpreserved memory countreset to 1 on every suspend.With
onCommit: Full, suspend captures a fullrunsc checkpoint(memory + fs) and resume restores it viarunsc restore.Verified end-to-end on kind (
create-kind-cluster.sh+install-ate-kind.sh): 3 POSTs (memory 3, file 3) -> suspend -> resume POST now returnspreserved memory count: 4 | preserved file counter: 4(previously memory reset to 1 while file continued to 4).onCommit:Full, onPause:Fullcase already covered byTestDurableDirLifecycle, plus manual end-to-end verification above)