Add optional Electron desktop packaging with bundled mini-bash#202
Open
yeyan00 wants to merge 1 commit into
Open
Add optional Electron desktop packaging with bundled mini-bash#202yeyan00 wants to merge 1 commit into
yeyan00 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an optional Electron desktop wrapper for Pi Web while leaving the existing web/CLI runtime unchanged.
Closes #201.
What changed
electron/main.cjsdesktop launcher that:BrowserWindow,PI_CODING_AGENT_DIRto ElectronuserData/agent,--agent-dir <path>and--portable,settings.json.shellPathto bundledbash.exewhen no valid shell path exists.desktop:devdesktop:packdesktop:distvendor/mini-bashfor Windows bash/coreutils support.Validation
node_modules/.bin/tsc --noEmitnpm run desktop:distdist-desktop/win-unpacked/Pi Web.exe --portable --port 30142http://127.0.0.1:30142/returns200 OKsettings.json.shellPathpoint at bundled mini-bashNotes