Add condition to test-stdlib and test-stdlib-golden to not run on push in ci-ubuntu - #3097
Queued
silas-hw wants to merge 8 commits into
Queued
Add condition to test-stdlib and test-stdlib-golden to not run on push in ci-ubuntu#3097silas-hw wants to merge 8 commits into
test-stdlib and test-stdlib-golden to not run on push in ci-ubuntu#3097silas-hw wants to merge 8 commits into
Conversation
gallais
reviewed
Jul 30, 2026
silas-hw
marked this pull request as draft
July 30, 2026 17:36
Contributor
Author
|
I'm going to force a failure to fully make sure the |
Contributor
Author
|
It works! I'll revert the 'test' commits |
silas-hw
marked this pull request as ready for review
July 30, 2026 18:29
gallais
approved these changes
Jul 30, 2026
JacquesCarette
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3094.
All this adds is a conditional (
if: ${{ github.event_name != 'push' }}) to the testing steps, as well as an extra step tohtml-deployto check for success due to the lack of conditional 'needs'.