feat: Handle errors on a consume task in the subscriber - #2947
pbonneaudiabolocom wants to merge 0 commit into
Conversation
|
@powersemmi that should fix the usage of the exception you raised when no group error is happennning. Any feedback on it ? |
e4f50e5 to
2258f50
Compare
IvanKirpichnikov
left a comment
There was a problem hiding this comment.
Hi. I don’t like the design of your feature. You need to use MethodType, you need to replace the method with another method, you need to override a private method. It looks very strange.
|
I agree that overriding private method is not great. People would overload the subscriber and implement their own task_exception_hook method. Might be easier to do... not sure it will work the same way. |
2258f50 to
fa474ef
Compare
fa474ef to
1ce2d1d
Compare
|
I closed that PR by mistake while removing the problematic code. I openned a new one here, much cleaner I would say. I'll tag you thre on it to get your feedbacks |
…sk in the subscriber.
Description
Whene a consume task fails, we can now adapt the behaviour of the system by overloading _handle_task_exception
Fixes #2945
Type of change
Please delete options that are not relevant.
Checklist
just lintshows no errors)just test-coveragejust static-analysis