You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci(zap): call the schedule delete and the gateway delete in the active scan seed - #133
The ZAP seed enrolls and claims a spare gateway. When ZAP_FULL is enabled, the full request list deletes the plug’s schedule and tries to delete the spare gateway with an incorrect password, then the correct password.
Changes: Gateway deletion scan requests
Layer / File(s)
Summary
Spare gateway and deletion requests .zap/seed.py
The seed enrolls and claims a spare gateway, then retains its ID. When ZAP_FULL is enabled, the request list deletes the plug’s schedule and attempts to delete the spare gateway first with an incorrect password and then with the correct password.
aethera-deeptech/backend#130: Adds the gateway deletion API and password contract used by the seed’s deletion request.
Merge Risk: Minimal · up to a39dd
This only changes the scan seed script in CI. It does not alter application behavior, and no merge-blocking risk was established.
Architecture risk: Low · up to a39dd
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.
Review details
Before / after behavior
observed — Modified behavior in .zap/seed.py: A second device key is generated, then used to enroll and claim a spare gateway; its ID is retained for later requests.
observed — Modified behavior in .zap/seed.py: The full request list now deletes the plug’s schedule and attempts to delete the spare gateway first with a wrong password and then with the correct password. Comments describe the expected replay and attack ordering.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly identifies the main change: adding schedule-delete and gateway-delete calls to the active scan seed.
Description check
The description directly relates to the changeset and explains the deletion calls and spare hub deletion.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
.zap/seed.py-199-199: 1
199-199: Major · Functional Correctness · Heavy lift
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Keep a gateway available for the active scan.
The replay deletes the spare gateway before the attack starts. The active scan therefore cannot exercise authorization or deletion against an existing gateway, so it can miss defects in those paths. Arrange for the attack to use a gateway that exists when its requests run.
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 28277581-5070-4490-997b-0129d8ac1349
Commits
Reviewing files that changed from the base of the PR and between 81809e7 and a39dd4b.
Files selected for processing: 1
.zap/seed.py
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.