docs(CHANGELOG): attribute fd_read_into to 0.510.0, which shipped it - #1478
Merged
Conversation
…[skip actions]
The 0.510.0 release left `## [current]` unrenamed, so VERSION said 0.510.0
while the newest heading was [current] — and the next release would have
claimed fd_read_into as 0.511.0.
Not a missing feature: release.yml:173-176 does the rename. It is a RACE. The
release workflow branches from main when it starts, and:
19:38:05 feat(io): fd_read_into committed
20:02:45 #1476 merged to main
20:03:03 #1475 (release 0.510.0) merged <- 18 seconds later
The release branch was cut before #1476 landed, so its `grep -q '## [current]'`
correctly found nothing to rename — the backfill had just consumed the previous
[current] and the new entry did not exist yet. The workflow behaved exactly as
written; the window is the problem.
This corrects the attribution only. The window itself is worth closing
separately — see the follow-up issue.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.510.0 release left
## [current]unrenamed, soVERSIONsaid0.510.0while the newest CHANGELOG heading was[current]— and the next release would have claimedfd_read_intoas 0.511.0.Not a missing feature — a race
release.yml:173-176does perform the rename. The problem is timing: the release workflow branches frommainwhen it starts.The release branch was cut before #1476 landed, so its
grep -q '## [current]'correctly found nothing to rename — the previous[current]had just been consumed by the backfill (#1474) and the new entry did not exist yet. The workflow behaved exactly as written; the window is the problem.This PR
Corrects the attribution only:
## [current]→## [0.510.0], one line.VERSIONand the newest heading now agree, and no duplicate heading is created.Verified after the change:
VERSION=0.510.0, newest heading =## [0.510.0], and the only duplicate headings in the file are the two pre-existing ones ([0.435.0],[0.497.0]) which this does not touch.The window itself
Filed as #1477, along with the two sibling failure modes in the same family — the pipeline silently shipping a release with no section (which is how 0.506.0–0.509.0 ended up empty), and the blind
sedbeing able to create a duplicate heading (which is how those two pre-existing duplicates arose). Three cheap independent guards suggested there; not attempted here, since a release-pipeline change wants its own review.🤖 Generated with Claude Code