Repository navigation
motion: kneel and stand up (#825's 5); keyed ways keep joints in range and step feet as a person does (#841 in part) - #844
Merged
Conversation
… its 5); ways keep their joints in range and step their feet as a person does (#841) Kneeling (motion.kneel, kneel_spot, kneeling, knelt, work_at): down stepping back on the left knee, then the right beside it, upright, then leant over the work with the hands moving over it; up by the half kneel. tests/test_kneel.ae holds it: a knee on the ground (1.9 cm), the hands at the work (3.0 cm), toes 4.0 mm, nothing drawn under 0.7 cm, 5.4 deg. Every keyed way: - a solve keeps its middle joint in range (a knee's 130 degrees), and a stepped foot its ankle's cone; a crouch rises to what the knees take; - the stage eased onto the animation puts each leg's end back where its solve had it, its hinge's lie kept (the eased leg dipped 9 cm); - a way begun while acting starts from the drawn pose (the neck snapped 58 degrees standing up from kneeling); - a stepped foot lifts, is carried at an even pace and set down, rides its shin, stays 3 cm clear, turns its toes up and swings wide round a folded knee where it must, planned over the stage; - the settle shifts the stance at 4 mm a step, under the slide bound. Getting up from the front, the kneeling feet tuck their toes under: the drawn feet went 8.8 cm into the ground, now 0.7 (tests/test_get_up_feet.ae fails on main). Up from the back its first stage still draws them 3.6 cm in: #841 stays open for that.
…eling (#841) At 130 degrees, a person's bend standing, the get-up's crouch over the feet asked the knees past it, and with the knees held to their range a lifted crouch turned the arms 6.2 degrees a step. At 149 the crouch is one the knees can take as keyed; face up turns 5.9 degrees at most.
nicolas-maman
added a commit
that referenced
this pull request
Oct 21, 2026
A macOS shard rebuilds nearly all it builds once the motion module moves: macos-2 built 67 programs in 1404 s on its three cores and was cut off at 25 minutes before its suites ran, as main's run after #844 was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kneeling by a point on the ground to work at it with both hands, and up again (#825's 5). Fixing it showed that the keyed ways asked the box man's joints for more than they have, and stepped feet badly, so this also fixes that for every keyed way (#841, in part).
Kneeling
motion.kneel(body, at, facing)kneels a figure by a point on the ground.kneel_spotsays where to stand for it, andkneeling,kneltandwork_atreport on it.stand_uprises the way the get-up's half kneel does.tests/test_kneel.ae:Every keyed way
tests/test_get_up_feet.aefails on main.crouch_within).Holds and follow-ups
feat/aether-0838, and ci.yml says so.The motion gate passed all 41 suites, kneel included.