Make vfs::tree::Kind pointer-sized - #654
Draft
jplatte wants to merge 1 commit into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
jplatte
marked this pull request as draft
January 2, 2026 17:39
By using impossible pointer values of AStr as the representation of the 'Regular' and 'Directory' kinds.
jplatte
force-pushed
the
jplatte/union-tree-kind
branch
from
January 3, 2026 10:36
a55402e to
50e9d98
Compare
Member
Author
|
Now rebased on #655.
|
jplatte
marked this pull request as ready for review
January 3, 2026 11:51
Member
Author
|
Not doing this for now. |
jplatte
marked this pull request as draft
January 3, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using impossible pointer values of AStr as the representation of the 'Regular' and 'Directory' kinds.