Skip to content

add serial queue #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aelam merged 1 commit into from
Aug 6, 2026
Merged

add serial queue #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Sources/JSONRPCConnection/StdioJSONRPCConnectionTransport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ public final class StdioJSONRPCConnectionTransport: JSONRPCServerTransport, @unc

private let jsonRPCParser = JSONPRCParser()

/// Serial queue for all stdout writes. Responses are produced concurrently
/// (JSONRPCConnection spawns a task per request), so without serialization
/// two messages' `write(header)` / `write(data)` calls interleave on the
/// shared stdout fd and corrupt the JSON-RPC framing — which makes the
/// client (SourceKit-LSP) read a mis-framed message and crash. A serial
/// queue guarantees each message is written atomically and in order.
private let writeQueue = DispatchQueue(label: "com.sourcekit-bsp.jsonrpc.stdout")

// Stream continuations for async streams
private var messageContinuation: AsyncStream<JSONRPCMessage>.Continuation?
private var errorContinuation: AsyncStream<JSONRPCTransportError>.Continuation?
Expand Down Expand Up @@ -165,7 +173,10 @@ public final class StdioJSONRPCConnectionTransport: JSONRPCServerTransport, @unc
group.addTask {
// Write operations with timeout protection
try await withCheckedThrowingContinuation { (continuation: CheckedContinuation<Void, Error>) in
DispatchQueue.global(qos: .userInitiated).async {
// Serial queue: header + data + flush for one message are
// written atomically relative to other messages, so the
// JSON-RPC framing on stdout is never interleaved.
self.writeQueue.async {
self.output.write(headerData)
self.output.write(data)
// Try to flush the output
Expand Down
Loading