feat: inline YouTube embeds in feed and post detail#2258
Open
mandolinman137 wants to merge 1 commit into
Open
Conversation
Gated by the existing "Embed External Media" setting. Renders a thumbnail with a play overlay; taps load a youtube-nocookie.com iframe that's portaled over the active slot so playback survives feed↔post navigation. Compact layout is unchanged.
Author
|
Addresses part of #530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
youtube-nocookie.comiframe only loads after a tap, so scrolling never pings Google.platformSupportsRedgif()gate on the Embed External Media toggle so it shows on web (YouTube doesn't need the native CORS bypass Redgifs does).URL detection covers:
youtube.com,youtu.be,m./music.subdomains,youtube-nocookie.com,youtubekids.com,yt.be, country TLDs (.de,.co.uk, etc.), and/watch,/embed/,/v/,/shorts/,/live/paths.Test plan
BlurOverlaylike other media.youtube-nocookie.com.pnpm testandpnpm test:typecheckpass. 15 new unit tests cover the URL detector (including a rejection for lookalike hosts likeyoutube.evil.com).Notes
index.htmlhas no CSP today)./shorts/{id}) are matched; YouTube Music URLs onmusic.youtube.comalso work./^youtube(?:\.[a-z]{2,4}){1,2}$/was too permissive and matchedyoutube.evil.com; tightened to/^youtube\.(?:[a-z]{2,3}|(?:co|com)\.[a-z]{2})$/.