Skip to content

Raid v2#1008

Open
maximeroucher wants to merge 27 commits into
mainfrom
Raid-V2
Open

Raid v2#1008
maximeroucher wants to merge 27 commits into
mainfrom
Raid-V2

Conversation

@maximeroucher

@maximeroucher maximeroucher commented May 17, 2026

Copy link
Copy Markdown
Member

Description

Summary

Restructuring some of raid registering to match challenger idea :

  • Edition system
  • Participant derived from coreuser instead of separate entity
  • Volunteer registration and handling

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

Comment thread app/core/core_endpoints/cruds_core.py Outdated
Comment thread app/modules/raid/utils/validation_checker.py Outdated
Comment thread tests/config.test.yaml Outdated
Comment thread tests/conftest.py Outdated
Comment thread tests/test_migrations.py Outdated
Comment thread app/modules/raid/cruds_raid.py
@PabloBellissant

Copy link
Copy Markdown

The CI checks are currently failing:
Lint and format / lintandformat (pull_request)

Could you please check the linting and formatting issues please ?

maximeroucher and others added 24 commits June 6, 2026 00:16
…hine

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…machine

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…olunteers

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…teers

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lunteer lookup

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… completeness

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…dition scoping

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…d volunteer flow

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…er flow

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@maximeroucher

Copy link
Copy Markdown
Member Author

Everything fixed, comment taken into accounts, if you want to check the changes.
Nice review, btw, raised only legitimate and fair points, GG for the level up !
Keep it up, the project is on really good hands ❤️

@maximeroucher maximeroucher requested a review from warix8 June 5, 2026 22:26
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.19549% with 174 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.57%. Comparing base (33f63b5) to head (fd37ae2).

Files with missing lines Patch % Lines
app/modules/raid/endpoints_raid.py 61.57% 83 Missing ⚠️
app/modules/raid/cruds_raid.py 65.21% 40 Missing ⚠️
app/modules/raid/utils/utils_raid.py 31.25% 22 Missing ⚠️
app/modules/raid/utils/validation_checker.py 91.26% 9 Missing ⚠️
app/modules/raid/schemas_raid.py 95.90% 7 Missing ⚠️
app/utils/initialization.py 0.00% 4 Missing ⚠️
app/core/google_api/google_api.py 0.00% 2 Missing ⚠️
app/core/payment/payment_tool.py 50.00% 2 Missing ⚠️
app/modules/raid/dependencies_raid.py 92.85% 2 Missing ⚠️
app/modules/raid/factory_raid.py 95.65% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   84.43%   83.57%   -0.87%     
==========================================
  Files         206      209       +3     
  Lines       14952    15441     +489     
==========================================
+ Hits        12625    12905     +280     
- Misses       2327     2536     +209     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

maximeroucher and others added 2 commits June 10, 2026 09:19
…ther track

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ion deletion

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants