fix(workspace): filter legacy embed paths for lint-clean runbook init#53
Open
advancedresearcharray wants to merge 1 commit into
Open
fix(workspace): filter legacy embed paths for lint-clean runbook init#53advancedresearcharray wants to merge 1 commit into
advancedresearcharray wants to merge 1 commit into
Conversation
go:embed all:templates ships every file on disk under templates/, including legacy runbook scaffolds (incidents/, postmortems/, procedures/) with placeholder wiki links that fail kiwifs check on generated workspaces. Wrap the embed FS with filteredTemplatesFS to exclude those paths and other dev-only dirs. Add service stubs for [[api-service]] and [[monitoring]] wiki links. Closes kiwifs#325 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go:embed all:templateswithfilteredTemplatesFSto exclude legacy runbook paths (incidents/,postmortems/,procedures/) that contain placeholder wiki links failingkiwifs check[[api-service]]and[[monitoring]]wiki links referenced by the example runbookTestRunbookEmbedUsesUC6ScaffoldOnly, embed filter unit tests, and existing runbook lint/init check tests passCloses kiwifs#325
Test plan
go test ./internal/workspace/... -run 'Runbook|Embed|Filtered' -count=1go test ./cmd/... -run 'Runbook|InitCheck' -count=1go test ./internal/workspace/... ./cmd/... -count=1TestRunbookInitCheckPassesexits 0 (info-level orphans only, no errors)TestRunbookTemplateLintCleanpasses on generated scaffoldMade with Cursor