feat(ui): keyboard shortcut cheat sheet overlay#47
Open
advancedresearcharray wants to merge 1 commit into
Open
feat(ui): keyboard shortcut cheat sheet overlay#47advancedresearcharray wants to merge 1 commit into
advancedresearcharray wants to merge 1 commit into
Conversation
717a762 to
44ecc0c
Compare
Replace the static shortcuts dialog with a searchable CommandDialog, add bare ? trigger outside inputs/editors, and expose a toolbar help button for mouse users. Closes kiwifs#428.
44ecc0c to
0d63b19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandDialog(cmdk fuzzy filter), grouped by Navigation / Views / Editor?trigger outside inputs and editors viashouldTriggerBareShortcutsHelp()HelpCirclebutton for mouse-accessible discoverymod+/continues to work via existingshortcuts_helpbindingCloses kiwifs#428
Test plan
cd ui && npm test -- --run— 33 files, 196 passed?outside an input/editor — overlay opensCmd+/(orCtrl+/) — overlay opensEscor click outside — overlay closes?while focused in editor/input — no overlay (typing preserved)Made with Cursor