[WIP] Fix failing GitHub Actions job Create GitHub Release - #368
Conversation
Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The release artifact excludes .node-version, so Node.js setup will fail unless hidden files are included or the repository is checked out.
Review details
Suppressed comments (1)
.github/workflows/release.yml:219
- This job does not check out the repository, so this file must come from the downloaded
release-buildartifact. However, the producer uploads.node-versionwithoutinclude-hidden-files: true, andupload-artifact@v7excludes hidden files by default;setup-nodewill therefore fail to resolve this file before npm runs. Update the artifact upload to include the hidden file (or check out the tag before this step) so the Node setup actually fixes the failing install.
node-version-file: '.node-version'
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
@copilot Improve htis |
Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
... Fixed in c218a28: enabled |
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.