Skip to content

MWPW-191478 M@S Fix overlap of badge and card title#989

Open
bozojovicic wants to merge 2 commits into
mainfrom
MWPW-191478
Open

MWPW-191478 M@S Fix overlap of badge and card title#989
bozojovicic wants to merge 2 commits into
mainfrom
MWPW-191478

Conversation

@bozojovicic

@bozojovicic bozojovicic commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Resolves https://jira.corp.adobe.com/browse/MWPW-191478
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Fix the overlap of badge and card title for card variants mini-compare-chart, mini-compare-chart-mweb and plans-education. For segment and product it was already working before.

Test pages :
https://mwpw-191478--mas--adobecom.aem.live/studio.html#fragmentId=ee321d09-3f61-4d19-985e-e6995075d25a&page=fragment-editor&path=sandbox
https://mwpw-191478--mas--adobecom.aem.live/studio.html#fragmentId=cdfc6905-a68d-4a70-a826-7bc3731022fc&page=fragment-editor&path=sandbox
https://mwpw-191478--mas--adobecom.aem.live/studio.html#fragmentId=9ae47485-f58b-4771-b82d-45cda20e0307&page=fragment-editor&path=sandbox

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@aem-code-sync

aem-code-sync Bot commented Jun 18, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.39%. Comparing base (692153c) to head (2875814).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   89.39%   89.39%   -0.01%     
==========================================
  Files         269      269              
  Lines       84202    84223      +21     
==========================================
+ Hits        75275    75292      +17     
- Misses       8927     8931       +4     
Files with missing lines Coverage Δ
web-components/src/merch-card.js 89.35% <100.00%> (+0.65%) ⬆️
...components/src/variants/mini-compare-chart-mweb.js 97.26% <100.00%> (+0.02%) ⬆️
web-components/src/variants/mini-compare-chart.js 78.76% <100.00%> (+0.08%) ⬆️
web-components/src/variants/plans.js 86.27% <100.00%> (-1.81%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692153c...2875814. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bozojovicic bozojovicic marked this pull request as ready for review June 18, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant