MWPW-198383: reconcile mini-compare-mweb collapsible list on resize#968
Open
joaquinrivero wants to merge 1 commit into
Open
MWPW-198383: reconcile mini-compare-mweb collapsible list on resize#968joaquinrivero wants to merge 1 commit into
joaquinrivero wants to merge 1 commit into
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
3a7fb48 to
39caac4
Compare
39caac4 to
f2e0b62
Compare
f2e0b62 to
fa889b9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
+ Coverage 89.20% 89.22% +0.02%
==========================================
Files 263 263
Lines 82698 82759 +61
==========================================
+ Hits 73767 73840 +73
+ Misses 8931 8919 -12
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
fa889b9 to
2f867c8
Compare
2f867c8 to
45946b9
Compare
45946b9 to
9e355f3
Compare
9e355f3 to
0769915
Compare
0769915 to
e581baa
Compare
e581baa to
04006d9
Compare
04006d9 to
93c1e49
Compare
The "what's included" toggle was configured once at first render, so crossing the mobile/desktop breakpoint left the list in the wrong mode — stuck expanded with no collapse control after desktop-to-mobile. Reconcile the toggle and cross-card heights on a matchMobile change listener, re-register it on reconnect (a DOM move reuses the instance and tears the listener down), and clear the grow-only synced heights on mobile so collapsed cards restore their natural height. Use a monotonic counter for fallback list ids to avoid Date.now() collisions across sibling cards.
93c1e49 to
2e8aaf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-198383
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
The mini-compare-chart-mweb card built its "what's included" toggle once, from the viewport at first render. Crossing the mobile/desktop breakpoint never updated it, so it stayed expanded with no collapse control after desktop-to-mobile. This reconciles the toggle and synced heights on every crossing.
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: