MWPW-198237: Fix OST and checkout links in compare-chart feature columns#962
MWPW-198237: Fix OST and checkout links in compare-chart feature columns#962yesil wants to merge 15 commits into
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
|
SNOW Change Request Transaction ID [STUDIO]: 0000019c1eec85a3-12e0fd06 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
+ Coverage 89.40% 89.45% +0.04%
==========================================
Files 269 269
Lines 84202 84245 +43
==========================================
+ Hits 75284 75362 +78
+ Misses 8918 8883 -35
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Axelcureno
left a comment
There was a problem hiding this comment.
Hydrate refactor looks good, and the removed @rte-focusout was genuinely dead.
One blocker: the guard's flags can get stuck. showOfferSelector only clears on select (rte-field.js:1558) — closing OST via Escape/backdrop/Cancel leaves it true, so the cell never deactivates and Escape gets swallowed. Link/icon editors' Cancel dispatches close, but rte-field only binds @save. Suggest clearing the flag on every OST close and binding @close.
Smaller: Escape-revert leaves referencedFragmentStoresHaveChanges stuck true; spectrum="swc" CTAs lose their listener through the innerHTML→unsafeHTML round-trip.
@Axelcureno dismissing your review, I could not reproduce the potential issues you reported.
seanchoi0
left a comment
There was a problem hiding this comment.
The showOfferSelector sticky-flag concern is still there — ost.js onCancel doesn't reset the flag, and #handleEscKey in rte-field.js skips it, so dismissing OST via Escape/backdrop could leave the cell locked. That said, Axelcureno already reviewed and made the call to ship, so deferring to that judgment.
|
@seanchoi0 similar comment from @Axelcureno as well, I tried and could not reproduce so left it as is. |
There was a problem hiding this comment.
@yesil
1)Plz resolve conflicts.
2) Applied button style is not rendered - Tracking here https://jira.corp.adobe.com/browse/MWPW-199105 (In case if it need to be handled separately as followup)
Applied 'Accent' style at https://mwpw-198237--mas--adobecom.aem.live/studio.html#fragmentId=c481dd2a-a079-47d7-9383-3dbeda5b0575&page=fragment-
editor&path=sandbox&tags=mas%3Astudio%2Fcontent-type%2Fcompare-chart

Observed that this is not rendered here:
https://main--da-express-milo--adobecom.aem.page/drafts/ilyas/pricing?milolibs=stage&maslibs=mwpw-198237--mas--adobecom&tab=1
Fixes the Offer Selector Tool (OST) and checkout links in mas-compare-chart feature columns.
#rteFieldHasOpenModalguards#deactivateRteCell, so opening OST inside a feature column keeps the cell alive. Removes the now-redundant@rte-focusouthandler.data-wcs-osicheckout links in thefeaturesslot are now transformed into buttons, matching description-slot behavior, via a new sharedprocessLinkshelper reused by bothprocessDescriptionLinksandprocessFeaturesLinks.hydrate.test.js).dist/mas.js+dist/merch-card.jsrebuilt and committed.Resolves https://jira.corp.adobe.com/browse/MWPW-198237
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
Test URLs:
Before: https://main--mas--adobecom.aem.live/
After: https://mwpw-198237--mas--adobecom.aem.live/
Express demo page:
Before: https://main--da-express-milo--adobecom.aem.page/drafts/ilyas/pricing?milolibs=stage
After: https://main--da-express-milo--adobecom.aem.page/drafts/ilyas/pricing?milolibs=stage&maslibs=mwpw-198237--mas--adobecom