feat: update embed block to latest aem-block-collection version - #141
Merged
Conversation
Sync blocks/embed with the current upstream implementation from adobe/aem-block-collection: - Adds poster-image placeholder + play button with autoplay for YouTube/Vimeo embeds - Drops dependency on buildFigure() from scripts.js - Removes Instagram, Adobe Spark/Adobe TV, TikTok, and SlideShare support (no longer present upstream); unmatched providers fall back to a generic iframe embed - CSS selectors updated from `main .embed` to `.embed` Verified clean via eslint and stylelint.
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs
blocks/embedwith the current upstream implementation from adobe/aem-block-collection.buildFigure()fromscripts.js(still used elsewhere byimages.jsandarticle-header.js, unaffected)main .embedto.embed, consistent with several other blocks in this repoTest plan
eslintclean onembed.jsstylelintclean onembed.css🤖 Generated with Claude Code