feat: show site header (gnav) + footer on the dashboard - #138
Merged
Conversation
The dashboard is a standalone HTML file served outside the AEM page pipeline, so it had no site chrome. Load the shared header (gnav, from /en/gnav) and footer (/footer) exactly as regular pages do — by importing lib-franklin's loadBlock/loadFooter and decorating <header>/<footer> — without running the full page pipeline (which would re-decorate the dashboard's custom markup). Also pull in /styles/styles.css for the nav/footer styling (loaded before the dashboard's own styles so the dashboard wins on conflicts) and reveal the body, since styles.css hides it until the boilerplate's .appear class which we don't run. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the normal site navigation (and footer) to the analytics dashboard, so it matches the rest of culture-tecture / re-think.
Why it was missing
admin/claps-analytics.htmlis a standalone HTML file served outside AEM's page-rendering pipeline, so it never got the header/footer that the boilerplate injects on authored pages.How
Reproduces exactly what regular pages do, but in a controlled way:
loadBlock/loadFooterfromlib-franklin.jsand decorates a<header>(thegnavblock, source/en/gnav) and<footer>(/footer).scripts.jspage pipeline — that would try to re-decorate the dashboard's bespoke markup (sections, buttons, blocks) and break the layout./styles/styles.css(before the dashboard's own<style>, so the dashboard wins on conflicts) for nav/footer styling, and reveals the body (styles.csshides it until the boilerplate adds.appear, which we now do).Verification
node --check.styles.css+ the gnav/footer blocks load without breaking the dashboard layout — title, KPI strip, tabs, and cards all render correctly, with the header bar reserved at top./en/gnav.plain.html) is authored content behind SSO, so it 404s on my local server and can't be shown here — it will populate on the real domain. Please eyeball it once deployed to confirm the nav looks right; if the spacing/full-width needs tweaking against the real nav, that's a quick follow-up.🤖 Generated with Claude Code