Skip to content

fix(up): handle non-parseable SSH git remote origin gracefully#2741

Merged
tripodsan merged 1 commit into
mainfrom
fix/ssh-origin-invalid-url
Jun 11, 2026
Merged

fix(up): handle non-parseable SSH git remote origin gracefully#2741
tripodsan merged 1 commit into
mainfrom
fix/ssh-origin-invalid-url

Conversation

@tripodsan

Copy link
Copy Markdown
Contributor

Summary

  • When the git remote origin uses a non-git@ SSH URL format (e.g. user@example.ghe.com:ACMEGROUP/racq-eds.git), GitUrl cannot parse it and throws Invalid URL, which previously crashed aem up with no useful message
  • If --url is not provided: a clear error now explains the SSH format limitation and suggests using --url
  • If a concrete --url is provided: the origin parse error is suppressed and startup continues normally using the provided URL

Test plan

  • shows helpful error when git remote origin uses non-parseable SSH format — verifies the friendly error message and early exit
  • starts successfully when non-parseable SSH origin is paired with --url — verifies the server starts and _url is set correctly from the provided --url
  • Full test suite passes (npm test exit 0)

🤖 Generated with Claude Code

When the git remote origin uses a non-git@ SSH format (e.g.
user@host:owner/repo.git), GitUrl throws Invalid URL which previously
crashed the CLI with no useful message.

Now: if --url is not provided, a clear error is shown explaining the
SSH format limitation and suggesting --url; if a concrete --url is
provided, the origin parse error is suppressed and startup continues.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tripodsan tripodsan requested a review from kptdobe June 11, 2026 08:27
@tripodsan tripodsan merged commit d2d34d4 into main Jun 11, 2026
9 checks passed
@tripodsan tripodsan deleted the fix/ssh-origin-invalid-url branch June 11, 2026 09:40
@tripodsan

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 16.20.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants