Skip to content

feat: add per-site /{site}/CONFIG permission for site config#293

Merged
bosschaert merged 2 commits into
mainfrom
site-config
Jun 17, 2026
Merged

feat: add per-site /{site}/CONFIG permission for site config#293
bosschaert merged 2 commits into
mainfrom
site-config

Conversation

@bosschaert

Copy link
Copy Markdown
Contributor

Description

Introduce a per-site config permission keyword /{site}/CONFIG that governs reading/writing site config (/config/{org}/{site}/...), mirroring how the org-level CONFIG keyword governs org config (/config/{org}).

Related Issue

Fixes: #292

How Has This Been Tested?

New unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Introduce a per-site config permission keyword `/{site}/CONFIG` that
governs reading/writing site config (/config/{org}/{site}/...), mirroring
how the org-level `CONFIG` keyword governs org config (/config/{org}).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Site config access is governed by the per-site /{site}/CONFIG keyword only
when such a rule is present in the permissions sheet. When no /{site}/CONFIG
rule is specified, site config access falls back to the org-level CONFIG rule.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@bosschaert bosschaert requested review from hannessolo and mhaack June 16, 2026 15:28
@bosschaert bosschaert merged commit f9002e9 into main Jun 17, 2026
8 of 9 checks passed
@bosschaert bosschaert deleted the site-config branch June 17, 2026 08:06
adobe-bot pushed a commit that referenced this pull request Jun 17, 2026
# [1.11.0](v1.10.2...v1.11.0) (2026-06-17)

### Features

* add per-site /{site}/CONFIG permission for site config ([#293](#293)) ([f9002e9](f9002e9))
@adobe-bot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a new permission to govern site-specific config access

4 participants