feat: add useragent #341
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,6 +85,19 @@ class RuntimeBaseCommand extends Command { | |
| } else if (flags.debug) { | ||
| createDebug.enable(flags.debug) | ||
| } | ||
|
|
||
| // set User-Agent for runtime calls | ||
| // ex. aio-cli-plugin-runtime/@adobe/aio-cli/10.3.1 (darwin-arm64; node-v18.20.4; zsh) | ||
| const vs = this.config.versionDetails | ||
| const baseUserAgent = `aio-cli-plugin-runtime/${vs?.cliVersion || 'unknown'}` | ||
| const userAgentDetails = [vs?.architecture, vs?.nodeVersion, vs?.shell] | ||
| .filter(detail => typeof detail === 'string' && detail.trim()) | ||
| // console.log('init ', this.config.versionDetails) | ||
| process.env.__OW_USER_AGENT = userAgentDetails.length > 0 | ||
|
There was a problem hiding this comment. Commented-out console.log debug statement should be removed before merging to keep the code clean. |
||
| ? `${baseUserAgent} (${userAgentDetails.join('; ')})` | ||
| : baseUserAgent | ||
|
|
||
| debug('init ', process.env.__OW_USER_AGENT) | ||
|
Comment on lines
+89
to
+100
There was a problem hiding this comment. New user-agent construction in |
||
| } | ||
|
|
||
| async handleError (msg, err) { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example UA in the comment doesn’t match what the code generates (example includes
@adobe/aio-cli/...and anode-v...format, while the actual string isaio-cli-plugin-runtime/${vs?.cliVersion} (...)). Update the comment to reflect the real output so it stays useful as documentation.